swss: Support for L2 table in ACL#2554
Open
ArthiGovindaraj wants to merge 2 commits intosonic-net:masterfrom
Open
swss: Support for L2 table in ACL#2554ArthiGovindaraj wants to merge 2 commits intosonic-net:masterfrom
ArthiGovindaraj wants to merge 2 commits intosonic-net:masterfrom
Conversation
Added new L2_TABLE_TYPE with needed qualifiers and actions Support for L2 match qualifiers like VLAN_ID, VLAN_PCP, VLAN_DEI SRC_MAC and DST_MAC
prsunny
reviewed
Dec 5, 2022
Collaborator
prsunny
left a comment
There was a problem hiding this comment.
adding l2 fields looks ok to me but we would need test coverage. also do you have any hld to link for the use-case?
Contributor
Author
|
Thanks for the feedback. I will update the test coverage and the HLD for the L2 ACL table requirement. |
Contributor
Author
|
VS test cases are updated and coverage passed. Please provide your feedback for the design document update : sonic-net/SONiC#1165 |
prsunny
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new L2_TABLE_TYPE with needed qualifiers and actions Support for L2 match qualifiers like VLAN_ID, VLAN_PCP, VLAN_DEI SRC_MAC and DST_MAC
What I did
Added support for L2_TABLE_TYPE in orchagent.
Related pull requests
sonic-net/sonic-utilities#2516
sonic-net/sonic-mgmt-common#66
Why I did it
ACL supports only L3 and L3V6 table type. There is no support for matching L2 fields in orchagent.
When user wants to match fields like SRC_MAC, DST_MAC, VLAN_ID, VLAN_PCP, VLAN_DEI we do not have support for these fields in orchagent.
Even, if we use TABLE_TYPE still we need to define and support the L2 match qualifiers. So, instead I have provided the complete support from CLICK.
How I verified it
"config acl add table -s ingress -p <table_name> L2"
"L2_TABLE|RULE_2": {
"SRC_MAC": "00:00:00:11:11:11/00:00:00:ff:ff:ff",
"DST_MAC": "00:00:00:22:22:22/00:00:00:ff:ff:ff",
"ETHER_TYPE": "0x0800",
"VLAN_ID": "100",
"VLAN_PCP": "5/7",
"VLAN_DEI": "1",
"PRIORITY": "5",
"PACKET_ACTION": "DROP"
}
"source-mac": "00:00:00:11:11:12",
"source-mac-mask": "00:00:00:ff:ff:ff",
"destination-mac": "00:00:00:11:11:13",
"destination-mac-mask": "00:00:00:ff:ff:ff",
"ethertype": "ETHERTYPE_ARP"
All the rules are added for each field and combinations as well. and each field tested with traffic in Broadcom based platform.
Details if related